Minor fixes to rcl_action #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
The clock type is instead as an argument to the action server's init function and stored in the impl. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Previously used to test compilation of rcl_action headers. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
added
in review
|
wjwwood
approved these changes
Feb 7, 2019
|
@jacobperron is this a candidate for backporting into Crystal? |
dirk-thomas
reviewed
Feb 7, 2019
| @@ -50,8 +50,6 @@ typedef struct rcl_action_server_options_t | |||
| /// Custom allocator for the action server, used for incidental allocations. | |||
| /** For default behavior (malloc/free), see: rcl_get_default_allocator() */ | |||
| rcl_allocator_t allocator; | |||
| /// Clock type used for checking result timeouts. | |||
| rcl_clock_type_t clock_type; | |||
There was a problem hiding this comment.
is this a candidate for backporting into Crystal?
No, this breaks ABI (and API).
nuclearsandwich
added a commit
to ros/rosdistro
that referenced
this pull request
Apr 15, 2019
Increasing version of package(s) in repository `rcl` to `0.7.0-3`: - upstream repository: https://github.com/ros2/rcl.git - release repository: https://github.com/ros2-gbp/rcl-release.git - file: `dashing/distribution.yaml` - bloom version: `0.8.0` - previous version for package: `0.7.0-2` ## rcl ``` * Added more test cases for graph API + fix bug. (#404 <ros2/rcl#404>) * Fixed missing include. (#413 <ros2/rcl#413>) * Updated to use pedantic. (#412 <ros2/rcl#412>) * Added function to get publisher actual qos settings. (#406 <ros2/rcl#406>) * Refactored graph API docs. (#401 <ros2/rcl#401>) * Updated to use ament_target_dependencies where possible. (#400 <ros2/rcl#400>) * Fixed regression around fully qualified node name. (#402 <ros2/rcl#402>) * Added function rcl_names_and_types_init. (#403 <ros2/rcl#403>) * Fixed uninitialize sequence number of client. (#395 <ros2/rcl#395>) * Added launch along with launch_testing as test dependencies. (#393 <ros2/rcl#393>) * Set symbol visibility to hidden for rcl. (#391 <ros2/rcl#391>) * Updated to split test_token to avoid compiler note. (#392 <ros2/rcl#392>) * Dropped legacy launch API usage. (#387 <ros2/rcl#387>) * Improved security directory lookup. (#332 <ros2/rcl#332>) * Enforce non-null argv values on rcl_init(). (#388 <ros2/rcl#388>) * Removed incorrect argument documentation. (#361 <ros2/rcl#361>) * Changed error to warning for multiple loggers. (#384 <ros2/rcl#384>) * Added rcl_node_get_fully_qualified_name. (#255 <ros2/rcl#255>) * Updated rcl_remap_t to use the PIMPL pattern. (#377 <ros2/rcl#377>) * Fixed documentation typo. (#376 <ros2/rcl#376>) * Removed test circumvention now that a bug is fixed in rmw_opensplice. (#368 <ros2/rcl#368>) * Updated to pass context to wait set, and fini rmw context. (#373 <ros2/rcl#373>) * Updated to publish logs to Rosout. (#350 <ros2/rcl#350>) * Contributors: AAlon, Dirk Thomas, Jacob Perron, M. M, Michael Carroll, Michel Hidalgo, Mikael Arguedas, Nick Burek, RARvolt, Ross Desmond, Sachin Suresh Bhat, Shane Loretz, William Woodall, ivanpauno ``` ## rcl_action ``` * Added Action graph API (#411 <ros2/rcl#411>) * Updated to use ament_target_dependencies where possible. (#400 <ros2/rcl#400>) * Fixed typo in Doxyfile. (#398 <ros2/rcl#398>) * Updated tests to use separated action types. (#340 <ros2/rcl#340>) * Fixed minor documentation issues. (#397 <ros2/rcl#397>) * Set symbol visibility to hidden for rcl. (#391 <ros2/rcl#391>) * Fixed rcl_action documentation. (#380 <ros2/rcl#380>) * Removed now unused test executable . (#382 <ros2/rcl#382>) * Removed unused action server option 'clock_type'. (#382 <ros2/rcl#382>) * Set error message when there is an invalid goal transition. (#382 <ros2/rcl#382>) * Updated to pass context to wait set, and fini rmw context (#373 <ros2/rcl#373>) * Contributors: Dirk Thomas, Jacob Perron, Sachin Suresh Bhat, William Woodall, ivanpauno ``` ## rcl_lifecycle ``` * Updated to use ament_target_dependencies where possible. (#400 <ros2/rcl#400>) * Set symbol visibility to hidden for rcl. (#391 <ros2/rcl#391>) * Contributors: Sachin Suresh Bhat, ivanpauno ``` ## rcl_yaml_param_parser ``` * Corrected bool reading from yaml files. (#415 <ros2/rcl#415>) * Added launch along with launch_testing as test dependencies. (#393 <ros2/rcl#393>) * Set symbol visibility to hidden for rcl. (#391 <ros2/rcl#391>) * Contributors: Michel Hidalgo, Sachin Suresh Bhat, ivanpauno ```
andre-rosa
pushed a commit
to andre-rosa/rosdistro
that referenced
this pull request
May 3, 2019
Increasing version of package(s) in repository `rcl` to `0.7.0-3`: - upstream repository: https://github.com/ros2/rcl.git - release repository: https://github.com/ros2-gbp/rcl-release.git - file: `dashing/distribution.yaml` - bloom version: `0.8.0` - previous version for package: `0.7.0-2` ## rcl ``` * Added more test cases for graph API + fix bug. (ros#404 <ros2/rcl#404>) * Fixed missing include. (ros#413 <ros2/rcl#413>) * Updated to use pedantic. (ros#412 <ros2/rcl#412>) * Added function to get publisher actual qos settings. (ros#406 <ros2/rcl#406>) * Refactored graph API docs. (ros#401 <ros2/rcl#401>) * Updated to use ament_target_dependencies where possible. (ros#400 <ros2/rcl#400>) * Fixed regression around fully qualified node name. (ros#402 <ros2/rcl#402>) * Added function rcl_names_and_types_init. (ros#403 <ros2/rcl#403>) * Fixed uninitialize sequence number of client. (ros#395 <ros2/rcl#395>) * Added launch along with launch_testing as test dependencies. (ros#393 <ros2/rcl#393>) * Set symbol visibility to hidden for rcl. (ros#391 <ros2/rcl#391>) * Updated to split test_token to avoid compiler note. (ros#392 <ros2/rcl#392>) * Dropped legacy launch API usage. (ros#387 <ros2/rcl#387>) * Improved security directory lookup. (ros#332 <ros2/rcl#332>) * Enforce non-null argv values on rcl_init(). (ros#388 <ros2/rcl#388>) * Removed incorrect argument documentation. (ros#361 <ros2/rcl#361>) * Changed error to warning for multiple loggers. (ros#384 <ros2/rcl#384>) * Added rcl_node_get_fully_qualified_name. (ros#255 <ros2/rcl#255>) * Updated rcl_remap_t to use the PIMPL pattern. (ros#377 <ros2/rcl#377>) * Fixed documentation typo. (ros#376 <ros2/rcl#376>) * Removed test circumvention now that a bug is fixed in rmw_opensplice. (ros#368 <ros2/rcl#368>) * Updated to pass context to wait set, and fini rmw context. (ros#373 <ros2/rcl#373>) * Updated to publish logs to Rosout. (ros#350 <ros2/rcl#350>) * Contributors: AAlon, Dirk Thomas, Jacob Perron, M. M, Michael Carroll, Michel Hidalgo, Mikael Arguedas, Nick Burek, RARvolt, Ross Desmond, Sachin Suresh Bhat, Shane Loretz, William Woodall, ivanpauno ``` ## rcl_action ``` * Added Action graph API (ros#411 <ros2/rcl#411>) * Updated to use ament_target_dependencies where possible. (ros#400 <ros2/rcl#400>) * Fixed typo in Doxyfile. (ros#398 <ros2/rcl#398>) * Updated tests to use separated action types. (ros#340 <ros2/rcl#340>) * Fixed minor documentation issues. (ros#397 <ros2/rcl#397>) * Set symbol visibility to hidden for rcl. (ros#391 <ros2/rcl#391>) * Fixed rcl_action documentation. (ros#380 <ros2/rcl#380>) * Removed now unused test executable . (ros#382 <ros2/rcl#382>) * Removed unused action server option 'clock_type'. (ros#382 <ros2/rcl#382>) * Set error message when there is an invalid goal transition. (ros#382 <ros2/rcl#382>) * Updated to pass context to wait set, and fini rmw context (ros#373 <ros2/rcl#373>) * Contributors: Dirk Thomas, Jacob Perron, Sachin Suresh Bhat, William Woodall, ivanpauno ``` ## rcl_lifecycle ``` * Updated to use ament_target_dependencies where possible. (ros#400 <ros2/rcl#400>) * Set symbol visibility to hidden for rcl. (ros#391 <ros2/rcl#391>) * Contributors: Sachin Suresh Bhat, ivanpauno ``` ## rcl_yaml_param_parser ``` * Corrected bool reading from yaml files. (ros#415 <ros2/rcl#415>) * Added launch along with launch_testing as test dependencies. (ros#393 <ros2/rcl#393>) * Set symbol visibility to hidden for rcl. (ros#391 <ros2/rcl#391>) * Contributors: Michel Hidalgo, Sachin Suresh Bhat, ivanpauno ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to some small things I noticed while using
rcl_action.