Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[foxy backport] fix test_info_by_topic flaky (#859) #944

Merged
merged 1 commit into from
Oct 15, 2021
Merged

[foxy backport] fix test_info_by_topic flaky (#859) #944

merged 1 commit into from
Oct 15, 2021

Conversation

jacobperron
Copy link
Member

Backport #859 to Foxy.

@fujitatomoya @jacobperron
fix test_info_by_topic flaky. (#859)
ea23929 
* fix test_info_by_topic flaky using GraphCache interface

Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
@jacobperron jacobperron mentioned this pull request Oct 14, 2021
Closed
@jacobperron jacobperron added this to Proposed in Foxy Patch Release 7 via automation Oct 14, 2021
@jacobperron jacobperron moved this from Proposed to Needs release in Foxy Patch Release 7 Oct 14, 2021
@jacobperron
Copy link
Member Author

Testing rcl:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@jacobperron jacobperron merged commit f91a556 into foxy Oct 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the jacob/foxy_backport_859 branch October 15, 2021 17:08
@Blast545
Copy link
Contributor

Thanks for backporting this! @jacobperron. Have you seen before these Windows CMake warnings? I haven't seen them in the buildfarm before, but I just checked the latest two ci_windows job you launched and they appeared there.

https://ci.ros2.org/job/ci_windows/15648/ and https://ci.ros2.org/job/ci_windows/15647/

@jacobperron jacobperron moved this from Needs release to Done in Foxy Patch Release 7 Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@Blast545 Blast545 Awaiting requested review from Blast545

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Foxy Patch Release 7
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jacobperron @Blast545 @clalancette @fujitatomoya