Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix buffer overflow in argument parsing caused by lexer returning length beyond length of string #979

Merged
merged 4 commits into from
Apr 18, 2022
Merged

Fix buffer overflow in argument parsing caused by lexer returning length beyond length of string #979

merged 4 commits into from
Apr 18, 2022

Commits on Apr 15, 2022

  1. Test that lexer never returns length longer than string 

    Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
    @sloretz
    sloretz committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    b5e51cf View commit details
    Browse the repository at this point in the history

  2. Fix bug where lexer returned length longer than string 

    Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
    @sloretz
    sloretz committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    596bf7c View commit details
    Browse the repository at this point in the history

  3. Test that peeking 2 ahead never goes beyond NONE or EOF 

    Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
    @sloretz
    sloretz committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    f48b561 View commit details
    Browse the repository at this point in the history

  4. Stop peeking if the first lexeme is NONE or EOF 

    Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
    @sloretz
    sloretz committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    a018531 View commit details
    Browse the repository at this point in the history