Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quality Declaration Statement for Rolling (master branch) #74

Merged
merged 17 commits into from
Apr 27, 2021
Merged

Quality Declaration Statement for Rolling (master branch) #74

merged 17 commits into from
Apr 27, 2021

Conversation

JanStaschulat
Copy link
Contributor

@JanStaschulat JanStaschulat commented Mar 31, 2021 •
edited
Loading

code quality assessment of rclc and rclc_lifecycle repository
see issue #59

@JanStaschulat
baseline quality declaration
86420e3 
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
@JanStaschulat
updated sections 2.x
f27be8f 
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
@JanStaschulat
updated section 3
084aec1 
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
@JanStaschulat
updated section 4 and 5
c13dac8 
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
@JanStaschulat
updated section 6
88de164 
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
@JanStaschulat
typo
f1ef977 
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
@JanStaschulat
code coverage
b03c89a 
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
@JanStaschulat
review
8d43ac3 
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
@JanStaschulat
review code quality, updated README.md code coverage badge
a7f7e41 
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@2a8ec69). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #74   +/-   ##
=========================================
  Coverage          ?   29.56%           
=========================================
  Files             ?       27           
  Lines             ?     2716           
  Branches          ?     1368           
=========================================
  Hits              ?      803           
  Misses            ?      765           
  Partials          ?     1148

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a8ec69...a7f7e41. Read the comment docs.

@JanStaschulat
minor changes
42d4dd1 
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
@JanStaschulat
quality statement for rclc_lifecycle
89a3105 
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
@JanStaschulat JanStaschulat changed the title quality declaration quality declaration statement Apr 1, 2021
@JanStaschulat JanStaschulat self-assigned this Apr 1, 2021
@JanStaschulat JanStaschulat requested a review from norro April 1, 2021 15:28
@JanStaschulat JanStaschulat marked this pull request as ready for review April 1, 2021 15:28
@JanStaschulat
Copy link
Contributor Author

@ralph-lange added quality statement for rclc and rclc_lifecycle

ralph-lange
ralph-lange requested changes Apr 1, 2021
View reviewed changes
rclc/QUALITY_DECLARATION.md Outdated Show resolved Hide resolved
rclc_lifecycle/QUALITY_DECLARATION.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
norro
norro approved these changes Apr 6, 2021
View reviewed changes
Copy link
Collaborator

@norro norro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Just one sentence I don't understand.

rclc/QUALITY_DECLARATION.md Outdated Show resolved Hide resolved
@JanStaschulat
updated 1.vi
8117834 
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
@JanStaschulat
updated 1.vi in rclc_lifecycle
627765f 
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2021 •
edited
Loading

Codecov Report

Merging #74 (6fb5f37) into master (905aaf9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
  Coverage   29.56%   29.56%              
==========================================
  Files         162       27     -135     
  Lines       16296     2716   -13580     
  Branches     8208     1368    -6840     
==========================================
- Hits         4818      803    -4015     
+ Misses       4590      765    -3825     
+ Partials     6888     1148    -5740
Impacted Files Coverage Δ
.../src/c32xmbze6sm/rclc/rclc/src/rclc/subscription.c
...u5qlju10njg/rclc/rclc/test/rclc/test_publisher.cpp
ros_ws/src/gyl4kwh6e3q/rclc/rclc/src/rclc/init.c
ros_ws/src/u5qlju10njg/rclc/rclc/src/rclc/client.c
...c/rclc_examples/src/example_executor_convenience.c
ros_ws/src/s1h97o2bzy/rclc/rclc/src/rclc/client.c
...c/9m6bct3klrf/rclc/rclc/src/rclc/executor_handle.c
...h97o2bzy/rclc/rclc/test/rclc/test_subscription.cpp
ros_ws/src/c32xmbze6sm/rclc/rclc/src/rclc/node.c
...3klrf/rclc/rclc_examples/src/example_client_node.c
... and 179 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 905aaf9...6fb5f37. Read the comment docs.

@JanStaschulat
finalized quality declaration for rclc and rclc_lifecycle, updated RE…
1eb6bd8 
…ADME

Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
@JanStaschulat
added codecov.yml to exclude test folders and rclc_examples folder
b968519 
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
@JanStaschulat
Merge branch 'master' into feature/quality-declaration
746b976
@JanStaschulat
added in section 'Developer Certificate of Origin ': Version 1.1
6fb5f37 
Signed-off-by: Jan Staschulat <jan.staschulat@de.bosch.com>
@JanStaschulat JanStaschulat changed the title quality declaration statement quality declaration statement for Rolling (master branch) Apr 26, 2021
@JanStaschulat JanStaschulat changed the title quality declaration statement for Rolling (master branch) 'Quality Declaration Statement' for Rolling (master branch) Apr 26, 2021
@JanStaschulat JanStaschulat changed the title 'Quality Declaration Statement' for Rolling (master branch) Quality Declaration Statement for Rolling (master branch) Apr 26, 2021
@JanStaschulat JanStaschulat mentioned this pull request Apr 26, 2021
Merged
This was referenced Apr 26, 2021
Merged
Closed
@JanStaschulat JanStaschulat linked an issue Apr 26, 2021 that may be closed by this pull request
Quality Declaration Statement #59
Closed
@JanStaschulat JanStaschulat merged commit 64ee9e1 into master Apr 27, 2021
@JanStaschulat JanStaschulat deleted the feature/quality-declaration branch April 27, 2021 12:50
MiguelCompany pushed a commit to eProsima/rclc that referenced this pull request Jun 6, 2023
@JanStaschulat
upgraded ros-tooling/setup-ros version (ros2#74)
9d8ab83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norro norro norro approved these changes

@ralph-lange ralph-lange ralph-lange approved these changes

Assignees

@JanStaschulat JanStaschulat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quality Declaration Statement
5 participants
@JanStaschulat @codecov-io @codecov-commenter @norro @ralph-lange