Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[foxy backport] Benchmark lifecycle features (#1462) #1471

Merged
merged 1 commit into from Nov 23, 2020
Merged

[foxy backport] Benchmark lifecycle features (#1462) #1471

merged 1 commit into from Nov 23, 2020

Conversation

brawner
Copy link
Contributor

@brawner brawner commented Nov 19, 2020

This backports the lifecycle benchmarks from #1462. This should probably wait for merging until performance_test_fixture is released into foxy as merging this PR will break rpr jobs.

  • Benchmark lifecycle features

Signed-off-by: Stephen Brawner brawner@gmail.com

@brawner
Benchmark lifecycle features (#1462)
e864f6a 
* Benchmark lifecycle features

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Cleanup

Signed-off-by: Stephen Brawner <brawner@gmail.com>
@brawner brawner requested a review from cottsay November 19, 2020 23:27
@brawner brawner changed the title Benchmark lifecycle features (#1462) [foxy backport] Benchmark lifecycle features (#1462) Nov 19, 2020
@brawner brawner added this to Proposed in Foxy Patch Release 4 via automation Nov 19, 2020
@brawner brawner moved this from Proposed to Needs release in Foxy Patch Release 4 Nov 19, 2020
@brawner
Copy link
Contributor Author

brawner commented Nov 19, 2020

Foxy job, with benchmarks on and testing --packages-select rclcpp_lifecycle

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@cottsay
Copy link
Member

cottsay commented Nov 20, 2020

@ros-pull-request-builder retest this please

@brawner
Copy link
Contributor Author

brawner commented Nov 20, 2020

Windows shows some ms build warnings which are not expected with performance jobs, but they were addressed in rolling and are awaiting a backport PR of ros2/rcutils#311

@cottsay
Copy link
Member

cottsay commented Nov 23, 2020

@ros-pull-request-builder retest this please

@brawner brawner merged commit bea9c5a into foxy Nov 23, 2020
@delete-merged-branch delete-merged-branch bot deleted the brawner/backport-1462 branch November 23, 2020 03:30
@brawner
Copy link
Contributor Author

brawner commented Nov 23, 2020

Thanks Scott for reminding me about this. Looks like the Fpr job went through cleanly.

@jacobperron jacobperron moved this from Needs release to Released in Foxy Patch Release 4 Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cottsay cottsay cottsay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Foxy Patch Release 4
Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brawner @cottsay