Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SharedFuture from async_send_request never becomes valid #2044

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Fix SharedFuture from async_send_request never becomes valid #2044

merged 1 commit into from
Dec 2, 2022

Conversation

llapx
Copy link
Contributor

@llapx llapx commented Nov 7, 2022

Signed-off-by: Lei Liu Lei.Liu.AP@sony.com

@llapx
Fix SharedFuture from async_send_request never becomes valid
ece7a0e 
Signed-off-by: Lei Liu <Lei.Liu.AP@sony.com>
@llapx llapx mentioned this pull request Nov 7, 2022
Closed
@llapx
Copy link
Contributor Author

llapx commented Nov 7, 2022

It seems Jenkins broken:

17:21:20 FATAL: command execution failed
17:26:12 java.nio.channels.ClosedChannelException
17:26:12 	at org.jenkinsci.remoting.protocol.impl.ChannelApplicationLayer.onReadClosed(ChannelApplicationLayer.java:209)
17:26:12 	at org.jenkinsci.remoting.protocol.ApplicationLayer.onRecvClosed(ApplicationLayer.java:221)
17:26:12 	at org.jenkinsci.remoting.protocol.ProtocolStack$Ptr.onRecvClosed(ProtocolStack.java:817)
17:26:12 	at org.jenkinsci.remoting.protocol.FilterLayer.onRecvClosed(FilterLayer.java:288)

Can anybody fix it?

@clalancette
Copy link
Contributor

It seems Jenkins broken:

With those sorts of errors, Jenkins will automatically re-run it, and it did. The latest one is failing because test_time_source failed. That probably bears looking into.

fujitatomoya
fujitatomoya approved these changes Nov 7, 2022
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fujitatomoya
Copy link
Collaborator

@iuhilnehc-ynos can you run CI for this?

@iuhilnehc-ynos
Copy link
Collaborator

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator

@iuhilnehc-ynos can you review this? i need another review before merge.

@fujitatomoya fujitatomoya merged commit 66b1944 into ros2:rolling Dec 2, 2022
@MiguelCompany
Copy link
Contributor

@fujitatomoya Should this be backported?

@fujitatomoya
Copy link
Collaborator

@Mergifyio backport to humble

@mergify mergify bot mentioned this pull request Jan 3, 2023
Merged
@mergify
Copy link

mergify bot commented Jan 3, 2023

backport to humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 3, 2023
@llapx @mergify
Fix SharedFuture from async_send_request never becomes valid (#2044)
3c4ddbe 
Signed-off-by: Lei Liu <Lei.Liu.AP@sony.com>
(cherry picked from commit 66b1944)
jefferyyjhsu pushed a commit to irobot-ros/rclcpp that referenced this pull request Jan 3, 2023
@llapx @jefferyyjhsu
Fix SharedFuture from async_send_request never becomes valid (ros2#2044)
ee35d01 
Signed-off-by: Lei Liu <Lei.Liu.AP@sony.com>
fujitatomoya pushed a commit that referenced this pull request Jan 6, 2023
@mergify @llapx
Fix SharedFuture from async_send_request never becomes valid (#2044) (#…
ce13f1a 
…2076)

Signed-off-by: Lei Liu <Lei.Liu.AP@sony.com>
(cherry picked from commit 66b1944)

Co-authored-by: Lei Liu <64953129+llapx@users.noreply.github.com>
@smkyle90 smkyle90 mentioned this pull request Apr 28, 2023
Open
alsora pushed a commit to irobot-ros/rclcpp that referenced this pull request Apr 29, 2023
@llapx
Fix SharedFuture from async_send_request never becomes valid (ros2#2044)
72d44df 
Signed-off-by: Lei Liu <Lei.Liu.AP@sony.com>
tkimura4 pushed a commit to tier4/rclcpp that referenced this pull request Aug 29, 2023
@mergify @llapx @tkimura4
Fix SharedFuture from async_send_request never becomes valid (ros2#2044…
a9bb35c 
…) (ros2#2076)

Signed-off-by: Lei Liu <Lei.Liu.AP@sony.com>
(cherry picked from commit 66b1944)

Co-authored-by: Lei Liu <64953129+llapx@users.noreply.github.com>
tkimura4 added a commit to tier4/rclcpp that referenced this pull request Aug 30, 2023
@tkimura4 @mergify @llapx
Fix SharedFuture from async_send_request never becomes valid (ros2#2044…
0189b7c 
…) (ros2#2076) (#6)

(cherry picked from commit 66b1944)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Lei Liu <64953129+llapx@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@iuhilnehc-ynos iuhilnehc-ynos iuhilnehc-ynos approved these changes

Assignees

@fujitatomoya fujitatomoya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@llapx @clalancette @fujitatomoya @iuhilnehc-ynos @MiguelCompany