-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not throw exception if trying to dequeue an empty intra-process buffer #2061
Conversation
…ffer Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
LGTM with green CI (please test |
Yes, that one seems unrelated, you can ignore it. |
Merging this as we have green CI. |
@alsora do we want to backport this to humble? |
This inconsistency has always been there (i.e. both in Humble and Galactic). The backport to humble should be conflicts-free, so yes we could do it. |
@Mergifyio backport humble |
✅ Backports have been created
|
do not throw exception if trying to dequeue an empty intra-process buffer
this PR enforces the same behavior that we already follow for non-ipc messages: there, the
take_and_do_error_handling
function handles gracefully trying to get data when it's not available.Signed-off-by: Alberto Soragna alberto.soragna@gmail.com