do not throw exception if trying to dequeue an empty intra-process buffer #2061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ffer Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
ivanpauno
approved these changes
Dec 13, 2022
|
LGTM with green CI (please test |
|
CI
|
|
Retry CI as the failure seems unrelated
|
Yes, that one seems unrelated, you can ignore it. |
|
Merging this as we have green CI. |
|
@alsora do we want to backport this to humble? |
|
This inconsistency has always been there (i.e. both in Humble and Galactic). The backport to humble should be conflicts-free, so yes we could do it. |
|
@Mergifyio backport humble |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not throw exception if trying to dequeue an empty intra-process buffer
this PR enforces the same behavior that we already follow for non-ipc messages: there, the
take_and_do_error_handlingfunction handles gracefully trying to get data when it's not available.Signed-off-by: Alberto Soragna alberto.soragna@gmail.com