Fixes to silence some clang warnings. #2127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does 2 separate things: * Adds (void)unused_variable things where needed. * Stops doing some checks on moved-from items in tests. With this in place, most of the remaining clang static analysis warnings are gone. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
mjcarroll
approved these changes
Mar 14, 2023
|
CI:
|
alsora
approved these changes
Mar 14, 2023
alsora
pushed a commit
to irobot-ros/rclcpp
that referenced
this pull request
Apr 28, 2023
This does 2 separate things: * Adds (void)unused_variable things where needed. * Stops doing some checks on moved-from items in tests. With this in place, most of the remaining clang static analysis warnings are gone. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Barry-Xu-2018
pushed a commit
to Barry-Xu-2018/rclcpp
that referenced
this pull request
Jan 12, 2024
This does 2 separate things: * Adds (void)unused_variable things where needed. * Stops doing some checks on moved-from items in tests. With this in place, most of the remaining clang static analysis warnings are gone. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does 2 separate things:
With this in place, most of the remaining clang static analysis warnings are gone.