Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type_hash to cpp TopicEndpointInfo #2137

Merged

Conversation

emersonknapp
Copy link
Collaborator

@emersonknapp emersonknapp commented Mar 22, 2023

Part of ros2/ros2#1159

From rep-2011 work, expose the new RMW endpoint info's type hash to the C++ endpoint struct.

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp emersonknapp force-pushed the emersonknapp/endpoint-type-hash branch from 84cadf2 to 7764edf Compare March 24, 2023 17:10
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp emersonknapp force-pushed the emersonknapp/endpoint-type-hash branch from 7764edf to 1ca1bfd Compare March 25, 2023 00:10
@emersonknapp emersonknapp marked this pull request as ready for review March 29, 2023 17:58
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@james-rms
Copy link

Gist: https://gist.githubusercontent.com/james-rms/fea80e655cfd2cff457bfdcf4608ad08/raw/3fa348b2ec65fc83f3763fa52cc69560fead4c11/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/11785

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@james-rms
Copy link

@ivanpauno @wjwwood @hidmic CI failure in github actions appears to be a flake, see passing CI runs in the comment above. It would help me to merge this, are you able to review?

@emersonknapp
Copy link
Collaborator Author

emersonknapp commented Apr 11, 2023

Not sure it's a flake so much as a temporary issue with some underlying package version - might be worth trying again to see if it's resolved with latest versions - regardless it's warnings, not test failures, and clearly not in any of the source files in this package

@clalancette
Copy link
Contributor

Not sure it's a flake so much as a temporary issue with some underlying package version - might be worth trying again to see if it's resolved with latest versions - regardless it's warnings, not test failures, and clearly not in any of the source files in this package

Yeah, this is currently broken. It will be resolved once we get the base set of packages released into Rolling.

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with green CI.

@clalancette
Copy link
Contributor

Looks good with green CI.

Actually, looks like CI was already green. The yellow on Windows was from an unrelated change (and has since been fixed). So I'm going to go ahead and merge this one.

@clalancette clalancette merged commit 3088b53 into ros2:rolling Apr 12, 2023
james-rms added a commit to ros2/rosbag2 that referenced this pull request Apr 14, 2023
Adds a type description hash to topic metadata.

Depends on ros2/rclcpp#2137
alsora pushed a commit to irobot-ros/rclcpp that referenced this pull request Apr 28, 2023
* Add type_hash to cpp TopicEndpointInfo

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Barry-Xu-2018 pushed a commit to Barry-Xu-2018/rclcpp that referenced this pull request Jan 12, 2024
* Add type_hash to cpp TopicEndpointInfo

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants