-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type_hash to cpp TopicEndpointInfo #2137
Add type_hash to cpp TopicEndpointInfo #2137
Conversation
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
84cadf2
to
7764edf
Compare
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
7764edf
to
1ca1bfd
Compare
3531f3a
to
2a08de5
Compare
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Gist: https://gist.githubusercontent.com/james-rms/fea80e655cfd2cff457bfdcf4608ad08/raw/3fa348b2ec65fc83f3763fa52cc69560fead4c11/ros2.repos |
@ivanpauno @wjwwood @hidmic CI failure in github actions appears to be a flake, see passing CI runs in the comment above. It would help me to merge this, are you able to review? |
Not sure it's a flake so much as a temporary issue with some underlying package version - might be worth trying again to see if it's resolved with latest versions - regardless it's warnings, not test failures, and clearly not in any of the source files in this package |
Yeah, this is currently broken. It will be resolved once we get the base set of packages released into Rolling. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with green CI.
Actually, looks like CI was already green. The yellow on Windows was from an unrelated change (and has since been fixed). So I'm going to go ahead and merge this one. |
Adds a type description hash to topic metadata. Depends on ros2/rclcpp#2137
* Add type_hash to cpp TopicEndpointInfo Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
* Add type_hash to cpp TopicEndpointInfo Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Part of ros2/ros2#1159
From rep-2011 work, expose the new RMW endpoint info's type hash to the C++ endpoint struct.