-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameter doesn't allow setting of name or value #238
Comments
Related enough to be mentioned here: |
I changed the title since |
We are using member-based access in ROS message classes. So I don't think we should add a method for these two fields. In C++ we generally don't have constructors with arguments (since the order would be problematic in case of future changes to the message). So the user has to set all fields after creating an instance. So I am not sure what the scope of this ticket is. If it is just about adding methods to set |
@dirk-thomas currently there is no way to change the name or value of an instance of |
It wasn't clear from the description that this ticket is referring to the We can either add those or just close this ticket since this is more a nice to have rather than preventing the user to use the class. |
* remove old memory tools * updates to use new memory_tools from osrf_testing_tools_cpp * fixup new test * fix lambda captures for Windows * uncrustify fix * extra_test_env -> rmw_implementation_env_var * Stray extra_test_libraries * Use default rmw impl outside of for_each_rmw_implementation loop * style fixup * fix typo
The
ParameterVariant
class requires the name and value (and thus type) of the variable to be passed to the constructor. To make it easier to use, we should addset_name()
andset_value()
methods.The text was updated successfully, but these errors were encountered: