Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ament_cmake_ros #444

Merged
merged 4 commits into from
Feb 26, 2018
Merged

Use ament_cmake_ros #444

merged 4 commits into from
Feb 26, 2018

Conversation

dhood
Copy link
Member

@dhood dhood commented Feb 24, 2018 •
edited
Loading

Revival of #390

Connects to ros2/ros2#306 but hasn't been tested with static linking ourselves

  • removed rmw dependency addition that seemed unrelated
  • updated to include rclcpp_lifecycle
  • removed the change from exec_depending on ament_cmake to ament_cmake_ros because from this PR I inferred the dependency is for normalize_path from ament_cmake itself.
  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status (unrelated linter errors)
  • Windows Build Status (unrelated linter errors)

@dhood dhood self-assigned this Feb 24, 2018
@dhood dhood added in progress Actively being worked on (Kanban column) in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Feb 24, 2018
@dhood dhood mentioned this pull request Feb 24, 2018
Merged
mikaelarguedas
mikaelarguedas approved these changes Feb 24, 2018
View reviewed changes
Copy link
Member

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Did you try to build it statically ?

wjwwood
wjwwood approved these changes Feb 24, 2018
View reviewed changes
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but should ament_export_dependencies(ament_cmake) be changed or removed? I'm honestly not sure if it should be exported or not.

@esteve esteve mentioned this pull request Feb 26, 2018
Closed
@dhood
Copy link
Member Author

dhood commented Feb 26, 2018

no, didn't try to build it statically

ament_export_dependencies(ament_cmake) was added in #444 so shouldn't be removed from my understanding

@dhood dhood merged commit 3786c91 into master Feb 26, 2018
@dhood dhood deleted the use_ament_cmake_ros branch February 26, 2018 17:46
@dhood dhood removed the in review Waiting for review (Kanban column) label Feb 26, 2018
@dhood
Copy link
Member Author

dhood commented Feb 26, 2018

since I didn't build it statically I connected this to ros2/ros2#306 in place of #390 so the changes are visible when people are testing that ticket

nnmm pushed a commit to ApexAI/rclcpp that referenced this pull request Jul 9, 2022
@xabxx @dirk-thomas
fix leak in test_expand_topic_name (ros2#444)
82f93af 
Signed-off-by: Abby Xu <abbyxu@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaelarguedas mikaelarguedas mikaelarguedas approved these changes

@wjwwood wjwwood wjwwood approved these changes

Assignees

@dhood dhood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhood @wjwwood @mikaelarguedas @esteve