-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Parameter Event Publisher settings #591 #614
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delayed response.
I went ahead and addressed the review comments and touched a few other things to move this along, thanks for the original changes @rarvolt! |
Looks like some things still need to be updated to use the new node signature, but I would like to defer until after this is merged: Which will make it much easier to do this pr without breaking downstream things, and merging this pr would break that one. |
…ettings Signed-off-by: RARvolt <rarvolt@gmail.com>
Signed-off-by: William Woodall <william@osrfoundation.org>
Signed-off-by: William Woodall <william@osrfoundation.org>
cdeb8dd
to
08a7ad8
Compare
Signed-off-by: William Woodall <william@osrfoundation.org>
Ok, rebased and updated to use the @jacobperron do you have time to re-review this? |
Signed-off-by: William Woodall <william@osrfoundation.org>
Thanks for the contribution @rarvolt! |
* Add ability to disable Parameter Event Publisher and change its QoS settings Signed-off-by: RARvolt <rarvolt@gmail.com> * address review comments Signed-off-by: William Woodall <william@osrfoundation.org> * use NodeOptions struct Signed-off-by: William Woodall <william@osrfoundation.org> * remove vestigial doc strings and improve docs Signed-off-by: William Woodall <william@osrfoundation.org> * fix lifecycle node constructor Signed-off-by: William Woodall <william@osrfoundation.org>
* Add support for taking a sequence of messages Signed-off-by: Michael Carroll <michael@openrobotics.org> * Fix uncrustify Signed-off-by: Michael Carroll <michael@openrobotics.org> * Apply suggestions from code review Co-Authored-By: Jacob Perron <jacob@openrobotics.org> Signed-off-by: Michael Carroll <michael@openrobotics.org> * Address reviewer feedback. Signed-off-by: Michael Carroll <michael@openrobotics.org> * Remove vertical whitespace Signed-off-by: Michael Carroll <michael@openrobotics.org> * Address reviewer feedback Signed-off-by: Michael Carroll <michael@openrobotics.org> * Remove blank line Signed-off-by: Michael Carroll <michael@openrobotics.org> Co-authored-by: Jacob Perron <jacob@openrobotics.org>
…ion (ros2#624) * Add tests for the test_validate_enclave_name module * Add test that is failing * Add test that is failing * Fix function used for publishing * Fix function used for publishing * Fix serialize subscription test * Fix serialize subscription test * Add tests for loan msgs and get_options * Add tests for loan msgs and get_options * Add support for taking a sequence of messages (ros2#614) * Add support for taking a sequence of messages * Fix uncrustify * Apply suggestions from code review * Address reviewer feedback. * Remove vertical whitespace * Address reviewer feedback * Remove blank line * Remove extra character left when rebasing * Remove test used for debugging * Remove repeated tests * Add test for get_options * Fix uncrustify errors Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
…ing team (ros2#614) Signed-off-by: Emerson Knapp <eknapp@amazon.com>
This PR adds the ability to disable Parameter Event Publisher and to set its QoS mentioned in #591