Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can change use_sim_time parameter type and delete it with CLI #732

Closed
jacobperron opened this issue May 22, 2019 · 2 comments
Closed

Can change use_sim_time parameter type and delete it with CLI #732

jacobperron opened this issue May 22, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@jacobperron
Copy link
Member

Bug report

Required Info:

  • Operating System:
    • Ubuntu 18.04
  • Installation type:
    • Debian packages
  • Version or commit hash:
    • 0.7.3
  • DDS implementation:
    • Fast-RTPS and Connext (not tested with OpenSplice)
  • Client library (if applicable):
    • rclcpp

Steps to reproduce issue

Run a demo node:

ros2 run demo_nodes_cpp listener

Try setting the parameter to something other than a Boolean:

ros2 param set listener use_sim_time foobar

Also, try deleting the parameter:

ros2 param delete listener use_sim_time

Expected behavior

It's expected that the use_sim_time parameter cannot be set to anything other than a Boolean and that it cannot be deleted.

Actual behavior

use_sim_time can be set to something other than a Boolean and can be deleted.

Additional information

An error is logged when trying to set use_sim_time with a different type, but the set appears to succeed anyways.

After deleting the parameter, if we try to set it again we get an error stating that the parameter is not declared:

$ ros2 param set listener use_sim_time True    
Setting parameter failed: parameter 'use_sim_time' cannot be set because it was not declared

I have not confirmed if this is just an issue with use_sim_time or parameters in general.
@jacobperron jacobperron added the bug Something isn't working label May 22, 2019
@jacobperron
Copy link
Member Author

@wjwwood FYI

@jacobperron jacobperron mentioned this issue May 22, 2019
Closed
@ivanpauno
Copy link
Member

IIUC, this was fixed in #875.

nnmm pushed a commit to ApexAI/rclcpp that referenced this issue Jul 9, 2022
@Blast545
Add mock tests, publisher 95% coverage (ros2#732)
beeeb3e 
* Add mimick test for rcl_publisher_get_subscription_count
* Remove const qualifiers
* Add missing mock suffix
* Improve test description
* Add mock test for rcl_publisher_assert_liveliness
* Add class to init publisher tests
* Add test for mocked rmw_publish
* Add mock test for rcl_publish_serialized
* Mock rcutils_string_map_init to make init fail
* Add mock test making rmw_publisher_get_actual_qos fail
* Add class to ease mimick usage
* Reformat tests to use helper class
* Add mocked rcutils_string_map_init to make init fail
* Add tests mocking loaned functions
* Add mock fail tests for publisher_init
* Add publisher fini fail mock tests
* Add nullptr tests
* Update mocking utilities
* Reformat with macro utility
* Add comments for mocked tests
* Check count_size value after test
* Reformat to use constexpr where possible
* Add variable making clear bad param test
* Add link to original file to help tracking changes

Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jacobperron @ivanpauno