[eloquent backport] Don't specify calling convention in std::_Binder template (#952) #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for a build error on 32-bit Windows. Member functions use the __thiscall convention by default which is incompatible with __cdecl. Signed-off-by: Sean Kelly <sean@seankelly.dev>
ivanpauno
approved these changes
Feb 27, 2020
|
@ros-pull-request-builder retest this please. |
1 similar comment
|
@ros-pull-request-builder retest this please. |
|
The failures shown in the different runs of the checker were different, and completly unrelated to this PR (just flaky tests). I will proceed to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for a build error on 32-bit Windows. Member functions use the
__thiscall convention by default which is incompatible with __cdecl.
Signed-off-by: Sean Kelly sean@seankelly.dev