-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(eloquent) Add operator!= to Duration #1279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'm having trouble determining what caused the build to go red.
😮 |
@ros-pull-request-builder retest this please (using custom job config from ros-infrastructure/ros_buildfarm#828) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending Docs test and the build passing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Oops, meant to review one of the other backports.)
Signed-off-by: Jannik Abbenseth <jannik.abbenseth@ipa.fraunhofer.de> Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
cf55061
to
a253b0c
Compare
@ros-pull-request-builder retest this please |
@ros-pull-request-builder retest this please (using custom job config from ros-infrastructure/ros_buildfarm#831) |
@ros-pull-request-builder retest this please |
Closing as eloquent is EOL |
Backports #1236.
This is an addition, not a bug fix.
It makes sense to me to backport this for consistency. It's weird to have all comparison operators except !=.