Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport foxy] Log error instead of throwing exception in Transition and State reset() mark no except (#1297) #1378

Merged
merged 2 commits into from Oct 5, 2020
Merged

[backport foxy] Log error instead of throwing exception in Transition and State reset() mark no except (#1297) #1378

merged 2 commits into from Oct 5, 2020

Conversation

brawner
Copy link
Contributor

@brawner brawner commented Oct 5, 2020

Backports #1297 for foxy

@brawner
Log error instead of throwing exception in Transition and State reset…
a6cba91 
…(), mark no except (#1297)

* Catch potential exception in destructor and log

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Remove thrown error from reset and mark it no except

Signed-off-by: Stephen Brawner <brawner@gmail.com>
@brawner
Copy link
Contributor Author

brawner commented Oct 5, 2020 •
edited

@jacobperron should I just backport the fix and not the API change? (marking reset() here noexcept)

@brawner brawner added this to Proposed in Foxy Patch Release 3 via automation Oct 5, 2020
@brawner brawner moved this from Proposed to Needs release in Foxy Patch Release 3 Oct 5, 2020
@jacobperron
Copy link
Member

@ros-pull-request-builder retest this please

@jacobperron
Copy link
Member

should I just backport the fix and not the API change? (marking reset() here noexcept)

Good question. It isn't clear to me if it is guaranteed to be ABI compatible. Perhaps it is safest to remove the noexcept.

@brawner
Remove noexcept for ABI compatibility
ff5f712 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
@brawner
Copy link
Contributor Author

brawner commented Oct 5, 2020

Testing --packages-select rclcpp_lifecycle

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@brawner brawner merged commit 6e6dd9c into foxy Oct 5, 2020
@delete-merged-branch delete-merged-branch bot deleted the brawner/rclcpp_lifecycle-backport-1297 branch October 5, 2020 22:45
@jacobperron jacobperron moved this from Needs release to Released in Foxy Patch Release 3 Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Foxy Patch Release 3
Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brawner @jacobperron