[foxy backport] Back port various unit tests for coverage part 3-ish #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
brawner
changed the title
ahcorde
approved these changes
Oct 7, 2020
brawner
force-pushed
the
brawner/rclcpp-backport-1272
branch
from
be9139a
to
4552f91
Compare
…h samples (#1274) Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* Add check for the correct number of messages received Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Refactor duplicate code into functions Add random jitter to generate non-zero standard deviation values Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Fix warning Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Fix conversion warnings Signed-off-by: Devin Bonnie <dbbonnie@amazon.com> * Fix style issues Signed-off-by: Devin Bonnie <dbbonnie@amazon.com>
* Add tests serialize functions * Add test getter const get_service_handle * Add basic tests getters publisher * Add == operator tests * Improve check on QOS depth * Remove extra line, copy directly string * Expect specific error throws Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
Without this change, I am unable to build locally. std_msgs is not declared as a test dependency or find_package'd anywhere, so I'm not sure why CI ever passed the build phase. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
* Add tests getters msg type support * Add missing fini * Add tests type_support services * Reformat to re use test structure * Remove not needed headers * Improve teardown test cases * Add nullptr checks to type_support tests * Reformat type_support testing * Replace expect tests with asserts * "Improve error msg for rcl_service_ini/fini fail" * Improve test readability Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
* Add mocking utils for rclcpp Signed-off-by: Stephen Brawner <brawner@gmail.com> * Add coverage for wait_set_policies Signed-off-by: Stephen Brawner <brawner@gmail.com> * Address PR feedback Signed-off-by: Stephen Brawner <brawner@gmail.com> * Fix windows issues Signed-off-by: Stephen Brawner <brawner@gmail.com> * Add test comment Signed-off-by: Stephen Brawner <brawner@gmail.com>
brawner
force-pushed
the
brawner/rclcpp-backport-tests-part3
branch
from
93f8947
to
fc83d32
Compare
brawner
changed the base branch from
brawner/rclcpp-backport-1272
to
brawner/rclcpp-backport-tests-part1
|
Rebase and merging onto #1383 so that can act as the ultimate feature branch. |
delete-merged-branch
bot
deleted the
brawner/rclcpp-backport-tests-part3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports various commits containing unit tests for increased coverage. It only contains changes for files in the test directory.
Bug fixes: #1270, #1274, #1281, #1291, #1310,
Coverage PRs: #1308, #1316