[foxy backport] Add ostream test for FutureReturnCode (#1327) #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While we are here, add in another test for the stream operator for future_return_code.cpp Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Stephen Brawner <brawner@gmail.com>
|
Testing
|
delete-merged-branch
bot
deleted the
brawner/rclcpp-backport-tests-part5
branch
brawner
added a commit
that referenced
this pull request
Oct 19, 2020
* Remove deprecated executor::FutureReturnCode APIs. (#1327) While we are here, add in another test for the stream operator for future_return_code.cpp Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> * Revert removing deprecated API Signed-off-by: Stephen Brawner <brawner@gmail.com> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports the unit test introduced it #1327 without removing the deprecation warning.
This will be squash merged into #1383, which will be ultimate be rebase merged back into foxy