Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial benchmark tests for rclcpp::init/shutdown create/destroy node #1411
Initial benchmark tests for rclcpp::init/shutdown create/destroy node #1411
Changes from all commits
544cdf1
2d2b969
45ec412
181e859
d29ae73
48c27ea
df156e1
7e1e39a
5304998
87d4af0
94bc919
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could never observe any change in behavior when I used these. Could you share the results with/without it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The difficult thing about comparing results with this is that
DoNotOptimize()
doesn't remove all optimizations. So sometimes it's important to include and sometimes it makes no difference. Because ultimately the compiler's optimizations will be different depending on the platform and optimization level, I thought it would be better to include it. Even though for this example it doesn't make much difference.Here are two simple examples which shows what gets optimized and what doesn't.
https://godbolt.org/z/c6aP3d with DoNotOptimize
https://godbolt.org/z/8ee5sT without
A little more context:
google/benchmark#242 (comment)