Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix failed windows ci of PR1781 by removing unnecessary RCLCPP_COMPONENTS_PUBLIC #1843

Merged
merged 1 commit into from
Dec 9, 2021
Merged

fix failed windows ci of PR1781 by removing unnecessary RCLCPP_COMPONENTS_PUBLIC #1843

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions rclcpp_components/include/rclcpp_components/component_manager_isolated.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ class ComponentManagerIsolated : public rclcpp_components::ComponentManager
/**
* \param node_id node_id of loaded component node in node_wrappers_
*/
RCLCPP_COMPONENTS_PUBLIC
void
add_node_to_executor(uint64_t node_id) override
{
Expand All @@ -77,7 +76,6 @@ class ComponentManagerIsolated : public rclcpp_components::ComponentManager
/**
* \param node_id node_id of loaded component node in node_wrappers_
*/
RCLCPP_COMPONENTS_PUBLIC
void
remove_node_from_executor(uint64_t node_id) override
{
Expand Down