Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the documentation for rclcpp::ok to be accurate. #1965

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Fix the documentation for rclcpp::ok to be accurate. #1965

merged 1 commit into from
Jul 7, 2022

Conversation

clalancette
Copy link
Contributor

That is, it returns false if shutdown has been called, and
true in all other circumstances.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

As pointed out by @jasonbeach in #3 (comment)

@clalancette
Fix the documentation for rclcpp::ok to be accurate.
3456a07 
That is, it returns false if shutdown has been called, and
true in all other circumstances.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette
Copy link
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya merged commit 37b589d into rolling Jul 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the clalancette/fix-rclcpp-ok-docs branch July 7, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alsora alsora alsora approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clalancette @alsora @fujitatomoya