rclcpp::Time::max() clock type support. (backport #2352) #2355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> (cherry picked from commit 76e2b26)
mergify
bot
requested review from
ivanpauno,
hidmic and
wjwwood
as code owners
fujitatomoya
approved these changes
Nov 4, 2023
|
CI:
|
clalancette
reviewed
Nov 5, 2023
| @@ -189,7 +189,7 @@ class Time | |||
| */ | |||
| RCLCPP_PUBLIC | |||
| static Time | |||
| max(); | |||
| max(rcl_clock_type_t clock_type = RCL_SYSTEM_TIME); // NOLINT | |||
There was a problem hiding this comment.
I don't know the answer to this, so this is just a question: does adding a default parameter to a method change the ABI? I would guess it does, but I'm not 100% sure about it.
There was a problem hiding this comment.
ah, i think we are introducing default argument here, that means changing default argument to the method, that is not guaranteed as ABI compatible change. (off topic, It would be nice if we have API/ABI checker with github workflow to add the lable on each PR for future enhancement.)
thanks for reminding me of that. i will go ahead to close this, and #2354
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #2352 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com