added wait method to AsyncParametersClient #337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While trying to rebase your PR I screwed up the remote branch and this got closed. Since I can't change the remote branch anymore I created #342 which contain your patch in a branch in this repo. I will run some CI builds for it. |
|
@BrannonKing I think my attempt to rebase your PR has also reset the master branch of your fork (which is the branch used for this PR) to the current master upstream. I am sorry for the inconvenience. 😯 |
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
…os2#337) * Add QoS to the GenericSubscription / GenericPublisher APIs Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to help me with CoreDX where its clients/services are not ready immediately upon creation. See #330