Remove a constructor that we can't test. #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are currently no paths that lead to it, and it has a bug anyway; if a large enough value is passed into sec, then we will overflow sec on the multiply. Just remove it since we can't reach the code anyway. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
clalancette
added
in progress
dirk-thomas
approved these changes
Jun 20, 2017
|
As suggested by @wjwwood , run a CI job to make sure nothing in the turtlebot demo uses this:
|
|
Approved, and this is building on all arches + TB2. Merging, thanks! |
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
* update test to IDL-based action generation * update test to IDL-based action generation * fix merge conflict * update new tests * update action types * match renamed action types * style fix * update types using unique_identifier_msgs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently no paths that lead to it, and it has
a bug anyway; if a large enough value is passed into sec,
then we will overflow sec on the multiply. Just remove it
since we can't reach the code anyway.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
CI: