Reimplement the fix a concurrency problem in the multithreaded executor #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reimplement the fix to correct a concurrency problem in the multithreaded executor. This time, the AnyExecutable class has a boolean flag to reset / not reset the callback group `can_be_taken_from_` variable on destruction. The multithreaded executor initializes the executor with that flag set to false. Issue: ros2#702 Signed-off-by: Guillaume Autran <gautran@clearpath.ai>
guillaumeautran
force-pushed
the
issue_702b
branch
from
a73f833
to
a4e6535
Compare
|
FYI: @wjwwood |
|
Thanks @guillaumeautran for opening this follow up. After reading through all of this, and seeing the comment in the destructor of So, unless you'd prefer to continue with this pull request, I'm ok to close it. In a different direction, it would be great to have a test that could reproduce this case. It seems like something that could easily regress with future work on the executor. |
|
@guillaumeautran Thanks for fixing the issue. Based on @wjwwood 's comment it sounds like the fix you made in #703 is the way to go, so I'll close this PR for now. |
nnmm
pushed a commit
to ApexAI/rclcpp
that referenced
this pull request
Jul 9, 2022
* Add bad param tests ini/fini rosout publisher * Make ini/fini_publisher_for_node public Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
* Add pause/resume to PlayerClock Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplement the fix to correct a concurrency problem in the multithreaded executor.
This time, the AnyExecutable class has a boolean flag to reset / not reset the callback group
can_be_taken_from_variable on destruction.The multithreaded executor initializes the executor with that flag set to false.
Issue: #702