Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segfault when destroying node while it is spinning in other thread #260

Closed
brawner opened this issue Jan 12, 2019 · 1 comment
Closed

Segfault when destroying node while it is spinning in other thread #260

brawner opened this issue Jan 12, 2019 · 1 comment

Comments

@brawner
Copy link
Contributor

brawner commented Jan 12, 2019

Bug report

MacOS 10.13.6
Building from master
Fast-RTPS
Rclpy
Required Info:

Destroying a node is not thread safe if it is spinning (rclpy.spin_once()) in another thread and will result in a segfault.

There are similar issues (#178, #253), but I don't think they are the exact same issue being posted here.

See the function test_destroy_node_while_spin_once() in:
https://github.com/brawner/rclpy/blob/test_destruction_outside_thread/rclpy/test/test_destruction_outside_thread.py
@brawner
Copy link
Contributor Author

brawner commented Jan 12, 2019

Actually, I realized this is the same general problem as #255. I'll just update that one.

@brawner brawner closed this as completed Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brawner