implicitly inherit from object #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaelarguedas
changed the title
mikaelarguedas
added
in review
dirk-thomas
reviewed
Aug 25, 2017
rclpy/rclpy/qos.py
Outdated
| @@ -17,7 +17,7 @@ | |||
| from rclpy.impl.implementation_singleton import rclpy_implementation as _rclpy | |||
|
|
|||
|
|
|||
| class QoSProfile(object): | |||
| class QoSProfile(): | |||
There was a problem hiding this comment.
Should the parenthesis be removed too?
There was a problem hiding this comment.
yes they should 👍
mikaelarguedas
force-pushed
the
homogenize_class_inheritence
branch
from
b375b59
to
f49f1b9
Compare
This was referenced Aug 25, 2017
dirk-thomas
approved these changes
Aug 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In python 3 classes implicitely inherit from object, so no need to express inheritence except if the class inherits from something else.
Addresses #104 (comment)