ServerGoalHandle should be destroyed before removing. #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Tamaki Nishino <otamachan@gmail.com>
|
CI:
|
clalancette
approved these changes
Apr 14, 2023
|
Woohoo! Is there any chance this might be backported to humble? |
|
We should probably wait for a while to see if this does not have any regression with rolling, but i think we can do that. CC: @clalancette @sloretz |
|
Hi! thanks for the fix, Is it possible to create a backport PR for humble so we could try it out? |
|
@Mergifyio backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 26, 2023
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Tamaki Nishino <otamachan@gmail.com> (cherry picked from commit 79ec706)
fujitatomoya
added a commit
that referenced
this pull request
May 17, 2023
|
Hey folks! Any idea when the next |
|
I guess we do not have concrete date for that so far, last patch was https://discourse.ros.org/t/preparing-for-humble-sync-and-patch-release-2023-05-02/31105. CC: @audrow |
|
@fujitatomoya: friendly ping? |
|
@audrow do you happen to know the next patch schedule for humble? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace #1070.
This PR addresses the following two issues.
ServerGoalHandle. (original issue https://answers.ros.org/question/411394/rclpy-action-server-seems-slowing-down-and-consuming-memory-in-long-term/)ActionServershould own theresult_future, butServerGoalHandle. (see Call destroy() before removing ServerGoalHandle #1070 (comment))@otamachan i borrowed your code from #1070, so added you as Co-Author.