Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typing in Node init args #1115

Merged
merged 1 commit into from May 1, 2023
Merged

Fix typing in Node init args #1115

merged 1 commit into from May 1, 2023

Conversation

russkel
Copy link
Contributor

@russkel russkel commented Apr 19, 2023

Fixes this typing issue:

Argument of type "None" cannot be assigned to parameter "parameter_overrides" of type "List[Parameter]" in function "__init__"
  Type "None" cannot be assigned to type "List[Parameter]"Pylance[reportGeneralTypeIssues](https://github.com/microsoft/pyright/blob/main/docs/configuration.md#reportGeneralTypeIssues)

@russkel
Fix type in Node init args
f0c58df 
Signed-off-by: Russ Webber <russ.webber@greenroomrobotics.com>
@russkel russkel changed the title Fix type in Node init args Fix typing in Node init args Apr 19, 2023
clalancette
clalancette approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, good call. Thanks for the contribution.

@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette clalancette merged commit 01a96e1 into ros2:rolling May 1, 2023
3 checks passed
@clalancette
Copy link
Contributor

@Mergifyio backport iron

@mergify
Copy link

mergify bot commented May 1, 2023 •
edited

backport iron

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 1, 2023
@russkel @mergify
Fix type in Node init args (#1115)
a9ac943 
Signed-off-by: Russ Webber <russ.webber@greenroomrobotics.com>
(cherry picked from commit 01a96e1)
@mergify mergify bot mentioned this pull request May 1, 2023
Merged
clalancette pushed a commit that referenced this pull request May 2, 2023
@mergify @russkel
Fix type in Node init args (#1115) (#1122)
2951464 
Signed-off-by: Russ Webber <russ.webber@greenroomrobotics.com>
(cherry picked from commit 01a96e1)

Co-authored-by: Russ <russ@rw.id.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@sloretz sloretz Awaiting requested review from sloretz sloretz is a code owner

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995 adityapande-1995 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@russkel @clalancette @fujitatomoya