Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get node's logger name from rcl #174

Merged
merged 3 commits into from
Feb 26, 2018
Merged

Get node's logger name from rcl #174

merged 3 commits into from
Feb 26, 2018

Conversation

dhood
Copy link
Member

@dhood dhood commented Jan 24, 2018

connects to ros2/rcl#212

Note that the rclpy logger associated with a node won't be created until after the rcl node is created. I don't see an issue with this because we're not using the logger before that point anyway.

@dhood dhood added the in progress Actively being worked on (Kanban column) label Jan 24, 2018
@dhood dhood self-assigned this Jan 24, 2018
@dhood dhood added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Feb 13, 2018
@dhood
Copy link
Member Author

dhood commented Feb 20, 2018

waiting for review @ros2/team

Copy link
Member

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I committed a tiny cosmetic change in 6b5053b.

@dhood dhood merged commit f3e52d9 into master Feb 26, 2018
@dhood dhood deleted the node_logger_name branch February 26, 2018 22:36
@dhood dhood removed the in review Waiting for review (Kanban column) label Feb 26, 2018
@dhood dhood mentioned this pull request Feb 26, 2018
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants