increase timeout as if this is running with connext as the default it… #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… takes much longer
dirk-thomas
approved these changes
Apr 17, 2018
|
Build without this patch timed out on rcply tests: https://ci.ros2.org/job/ci_linux/4242/testReport/junit/(root)/projectroot/rclpytests/ With this patch it passed: https://ci.ros2.org/job/ci_linux/4243/ As this is already approved, I'm merging it without stopping by the review column |
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… takes much longer
Tested this locally and it takes ~130 seconds for me with connext.
I put 200 as I expect it to take longer on slower machines
Examples of jobs failing when ran with connext only:
https://ci.ros2.org/job/ci_osx/3482/
https://ci.ros2.org/job/ci_linux/4235/
Jobs with this change:
https://ci.ros2.org/job/ci_linux/4241
Waiting for CI to come back to place this in review