Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of -r/--remap flags where appropriate. #411

Merged
merged 1 commit into from
Sep 3, 2019

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Aug 29, 2019

Precisely what the title says.

Connected to ros2/rcl#491.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check #405 (comment) before going ahead with this.

Otherwise, looks good to me.

@hidmic hidmic merged commit 36e1841 into master Sep 3, 2019
@delete-merged-branch delete-merged-branch bot deleted the hidmic/use-cli-remap-flags branch September 3, 2019 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants