Cleanup rmw publisher/subscription on exception #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion() fails Signed-off-by: Miaofei <miaofei@amazon.com>
Signed-off-by: Miaofei <miaofei@amazon.com>
|
@ros2/aws-oncall - please run this CI job Can you also please additionally run with Note: This |
ivanpauno
approved these changes
May 1, 2020
|
See CI jobs here ros2/ros2cli#496 (comment). |
|
Merging this one, thanks for the fix @mm318 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned at ros2/ros2cli#500 (comment) and ros2/ros2cli#500 (comment), when
create_publisher()/create_subscription()fails to register QoS event callbacks, there should not remain a danglingrmw_publisher_t/rmw_subscription_tinstance until Python performs garbage collection.This pull request changes the behavior of
create_publisher()/create_subscription()so that it eagerly destroys the just newly createdrmw_publisher_t/rmw_subscription_tinstance if an exception occurs.