Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use absolute parameter events topic name #612

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Use absolute parameter events topic name #612

merged 1 commit into from
Aug 4, 2020

Conversation

ivanpauno
Copy link
Member

Follow up of ros2/rclcpp#929.

@ivanpauno
Use absolute parameter events topic name
2e75de7 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the enhancement New feature or request label Aug 3, 2020
@ivanpauno ivanpauno self-assigned this Aug 3, 2020
@jacobperron
Copy link
Member

jacobperron commented Aug 3, 2020 •
edited
Loading

Sorry, missed this before opening my own (#613)

@jacobperron jacobperron mentioned this pull request Aug 3, 2020
Closed
@jacobperron
Copy link
Member

jacobperron commented Aug 3, 2020 •
edited
Loading

Note, I've already triggered a full CI run (together with the rclcpp change):

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status (unrelated test failures in rcl)

@jacobperron jacobperron merged commit 1bdd3ce into master Aug 4, 2020
@delete-merged-branch delete-merged-branch bot deleted the ivanpauno/absolute-parameters-events-topic branch August 4, 2020 01:40
@jacobperron jacobperron mentioned this pull request Aug 5, 2020
Merged
jacobperron pushed a commit that referenced this pull request Aug 6, 2020
@ivanpauno @jacobperron
Use absolute parameter events topic name (#612)
e327e14 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@jacobperron jacobperron mentioned this pull request Aug 6, 2020
Merged
crystaldust pushed a commit to crystaldust/rclpy that referenced this pull request Sep 10, 2020
@ivanpauno @crystaldust
Use absolute parameter events topic name (ros2#612)
84fa552 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
jacobperron added a commit that referenced this pull request Nov 6, 2020
@jacobperron @ivanpauno
Use absolute parameter events topic name (#612) (#614)
72ab150 
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>

Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

Assignees

@ivanpauno ivanpauno

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanpauno @jacobperron