Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bad_alloc return to topic_endpoint_info functions #269

Merged
merged 1 commit into from
Aug 28, 2020

Conversation

brawner
Copy link
Contributor

@brawner brawner commented Aug 27, 2020

From feedback on #254, it was recommended to add a bad_alloc return to topic_endpoint_info functions that do string duplication with an allocator.

Signed-off-by: Stephen Brawner brawner@gmail.com

Signed-off-by: Stephen Brawner <brawner@gmail.com>
@brawner brawner self-assigned this Aug 27, 2020
@brawner
Copy link
Contributor Author

brawner commented Aug 27, 2020

Testing --packages-select rmw

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link

@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brawner brawner merged commit 3db0cfa into master Aug 28, 2020
@delete-merged-branch delete-merged-branch bot deleted the brawner/bad-alloc-ret branch August 28, 2020 21:10
ahcorde pushed a commit that referenced this pull request Oct 13, 2020
Signed-off-by: Stephen Brawner <brawner@gmail.com>
ahcorde pushed a commit that referenced this pull request Oct 13, 2020
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants