Quality declarations for rmw and rmw_implementation_cmake #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
brawner
force-pushed
the
quality_declaration
branch
2 times, most recently
from
d80ff77
to
0e75fac
Compare
|
Updating to reflect current QL status (4). |
ahcorde
requested changes
Apr 24, 2020
|
|
||
| ### License [3.iii] | ||
|
|
||
| The license for `rmw_implementation_cmake` is Apache 2.0, and a summary is in each source file, the type is declared in the `package.xml` manifest file, and a full copy of the license is in the `LICENSE` file. |
There was a problem hiding this comment.
Suggested change
| The license for `rmw_implementation_cmake` is Apache 2.0, and a summary is in each source file, the type is declared in the `package.xml` manifest file, and a full copy of the license is in the `LICENSE` file. | |
| The license for `rmw_implementation_cmake` is Apache 2.0, and a summary is in each source file, the type is declared in the [package.xml](./package.xml) manifest file, and a full copy of the license is in the [LICENSE](../LICENSE) file. |
Signed-off-by: Stephen Brawner <brawner@gmail.com>
brawner
force-pushed
the
quality_declaration
branch
from
0e75fac
to
5247b6e
Compare
ahcorde
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including aspirational quality declarations for
rmwandrmw_implementation_cmake. While this only has one commit, it does technically depend on #203 and #204 and should be rebased when they are merged.Signed-off-by: Stephen Brawner brawner@gmail.com