Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for untested public functionality #203

Merged
merged 2 commits into from
Apr 27, 2020
Merged

Add tests for untested public functionality #203

merged 2 commits into from
Apr 27, 2020

Conversation

brawner
Copy link
Contributor

@brawner brawner commented Mar 24, 2020

This PR adds a bunch of simple tests for currently untested public API functionality. Gives a quick boost to coverage!

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status
  • Coverage Build Status

Signed-off-by: Stephen Brawner brawner@gmail.com

@brawner
Copy link
Contributor Author

brawner commented Mar 24, 2020 •
edited
Loading

Adding some code to increase coverage a bit more.

  • Linux Build Status
  • Linux-aarch64Build Status
  • macOS Build Status
  • Windows Build Status
  • Coverage Build Status

This was referenced Mar 25, 2020
Merged
Closed
ahcorde
ahcorde requested changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just correct the License in test_allocator.cpp

During the las days some cahnges has happen in the library. Probably it makes sense to rebase with master and rerun CI

rmw/test/test_allocators.cpp Outdated Show resolved Hide resolved
@brawner
Copy link
Contributor Author

brawner commented Apr 21, 2020

Rerunning CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

ahcorde
ahcorde requested changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix conflicts with master

@brawner
Add tests for untested public functionality
b72090b 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
@brawner
PR Fixup
f93825f 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
@brawner
Copy link
Contributor Author

brawner commented Apr 24, 2020

Fixed conflicts

@ahcorde
Copy link
Contributor

ahcorde commented Apr 24, 2020

@brawner can we relaunch test? just in case

@brawner
Copy link
Contributor Author

brawner commented Apr 24, 2020

Good call

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 8ecc953 into ros2:master Apr 27, 2020
@sloretz sloretz mentioned this pull request Apr 28, 2020
Closed
@brawner brawner mentioned this pull request Jun 9, 2020
Closed
@nnmm nnmm mentioned this pull request Oct 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees

@brawner brawner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brawner @ahcorde