new api to support wait_for_service #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
wjwwood
added
in review
|
I'm putting this up for review. |
|
+1 |
| * The given client and node must match, i.e. the client must have been created | ||
| * using the given node. | ||
| * | ||
| * The is_available parameter must not be NULL, and must point a bool variable. |
ahcorde
pushed a commit
to erlerobot/rmw
that referenced
this pull request
Jun 2, 2016
* new api to support wait_for_service * is_ready -> is_available * doc fixups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my proposed API additions needed to support the
wait_for_servicefunctionality at the client library level. A similar set of functions would be inrcl(or else aliased to these functions), and the client libraries can implementwait_for_serviceusing these two functions.Looking for feedback before/while fixing up changes to each rmw implementation to implement these additions.
Connects to ros2/ros2#215