Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move getenv from rcl to here for more reuse #87

Closed
wants to merge 3 commits into from

Conversation

wjwwood
Copy link
Member

@wjwwood wjwwood commented Dec 13, 2016

Connects to ros2/rmw_fastrtps#79

@wjwwood wjwwood added the in progress Actively being worked on (Kanban column) label Dec 13, 2016
@dirk-thomas
Copy link
Member

I don't think rmw is a good location for those since it has nothing to do with the ROS middleware interface. Maybe a new package for those functions would be a good idea (so that it can be used from rmw implementations as well as rcl*).

@Karsten1987
Copy link
Contributor

btw, should we close this in favor of ros2/rcutils#2 ?

@wjwwood
Copy link
Member Author

wjwwood commented Mar 29, 2017

@Karsten1987 I'd say that we should use this implementation (documentation, signature, and implementation, if they're not already identical to what's in ros2/rcutils#2) before this is closed. I spent a good deal of time tweaking this implementation to work the same on Windows and Unix without any inconsistencies and avoiding memory allocation if possible.

@wjwwood
Copy link
Member Author

wjwwood commented Mar 29, 2017

Or at least as nearly as possible, given that this implementation uses RMW_* defines.

@mikaelarguedas
Copy link
Member

the implementation in ros2/rcutils#2 will be identical on behaviour and argument type. The return codes will be different though

@wjwwood
Copy link
Member Author

wjwwood commented Apr 4, 2017

Closing in favor of ros2/rcutils#2

@wjwwood wjwwood closed this Apr 4, 2017
@wjwwood wjwwood deleted the configure_fastrtps_ttl branch April 4, 2017 03:41
@wjwwood wjwwood removed the in progress Actively being worked on (Kanban column) label Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants