[connext_dynamic] currently broken

[dirk-thomas]

As a regression of #194 the dynamic rmw implementation doesn't function anymore. Even for simple pub/sub examples the executables crash in the new add_information calls.

[Karsten1987]

As far as I can tell, the current master branch does not even compile. Is it worth putting an AMENT_IGNORE in it until it's fixed? I think it's important that every fresh checkout of the ros2.repos file compiles as is.

[mikaelarguedas]

Slightly more context: broken since the type change (char => signed char) introduced by ros2/rosidl#211.
We should decide if we should drop AMENT_IGNORE files in all not currently supported rmw_implementations (and remove them in ci when needed) or any other solution to avoid users checking out the ros2.repos file to have a workspace not compiling

[dirk-thomas]

We have talked about this case in the last meeting. I still think we should keep the unsupported rmw impl. as close in sync as possible. If we don't the technical debt while pile up and it will "cost" us much more to revisit this in the future. Especially when the patch is as simple as #222 (and it is easy now since all our memory about recent changes is fresh).

[mikaelarguedas]

closed via #222

[dirk-thomas]

This is not fixed. rmw_connext_dynamic_cpp still doesn't "work" - it only compiles again. Reopened.

[mikaelarguedas]

oh sorry I thought the scope of this was "compilation broken" not "runtime broken", thanks for catching that

[clalancette]

Closing, since with Foxy now being End-of-Life, this repository is no longer used.