This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
C services #141
Merged
C services #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this doesn't totally work yet. I need to change the generate_interfaces.cmake to properly depend on the interfaces generated by rosidl_generator_cpp and rosidl_typesupport_connext_cpp... |
jacquelinekay
force-pushed
the
c_services
branch
from
a1991d1
to
f22898d
Compare
|
should be working now |
jacquelinekay
force-pushed
the
c_services
branch
7 times, most recently
from
738c94d
to
906e52c
Compare
jacquelinekay
force-pushed
the
c_services
branch
from
c822b7d
to
2a48389
Compare
| @@ -0,0 +1,91 @@ | |||
| // generated from rosidl_typesupport_connext_cpp/resource/srv__type_support.hpp.template | |||
|
Just finished reviewing the code and I don't have any comments to add. lgtm |
|
I'm going to relaunch CI just in case then squash and merge all c_services branches if clean. |
jacquelinekay
force-pushed
the
c_services
branch
from
d17ce1f
to
4df000b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to ros2/rcl#27
based on #140
Yet another C services pull request.
Provide a generated library that creates the expected C structures for service-related callbacks and calls directly to the C++ implementation.
Again it's a bit strange that C type support depends so much on C++ type support. Perhaps we should reverse the dependency so that C++ depends on C. Regardless, I think that the principal of it is fairly sound to reduce code duplication.