This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
set connext buffer capacity #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
jacobperron
approved these changes
Apr 28, 2020
mjcarroll
approved these changes
Apr 28, 2020
delete-merged-branch
bot
deleted the
serialized_message_move_constructor
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests in fail because of Connext not setting the buffer capacity of the serialized message.
This hasn't been a problem in the past, but with ros2/rclcpp#1075 we introduce a check for correct initialization here: https://github.com/ros2/rclcpp/pull/1075/files#diff-1a8c71aa102b5d8fc8e86cf3f56f42aeR58
Connects to ros2/rclcpp#1097