Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serializer copies data a bit more often than necessary #9

Closed
eboasson opened this issue Jun 16, 2019 · 1 comment
Closed

Serializer copies data a bit more often than necessary #9

eboasson opened this issue Jun 16, 2019 · 1 comment

Comments

@eboasson
Copy link
Collaborator

The serialization happens by simply appending to std::vector — I'm sure that's not the most efficient way to do it. At the very least the fixed-size message could have the vector allocated to the correct size from the start.
@rotu
Copy link
Collaborator

rotu commented Mar 24, 2020

Fixed in #42

@rotu rotu closed this as completed Mar 24, 2020
mauropasse pushed a commit to mauropasse/rmw_cyclonedds that referenced this issue Feb 9, 2021
Merge pull request ros2#9 from mauropasse/mauro/clean-events-executor
18a41f5 
Reorder APIs arguments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rotu @eboasson