Support for ON_REQUESTED_INCOMPATIBLE_QOS and ON_OFFERED_INCOMPATIBLE_QOS events #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mm318 thanks for adding support for these events! The changes look good to me, I don't see any issues. |
eboasson
reviewed
Mar 25, 2020
There was a problem hiding this comment.
Thanks @mm318, I see only one problem and that is compatibility with Dashing and Eloquent (which as of today we still maintain in the Cyclone DDS RMW layer). I think all the new things are part of the Foxy RMW interface, so that would make them conditional on RMW_VERSION_GTE(0,8,2), similar to getting topic endpoint info (see, e.g., line 54).
Signed-off-by: Miaofei <miaofei@amazon.com>
Signed-off-by: Miaofei <miaofei@amazon.com>
|
Thanks, @eboasson. I have added |
eboasson
approved these changes
Mar 26, 2020
There was a problem hiding this comment.
Thanks @mm318 . I think this PR is dependent on ros2/rmw#193 so I'll let you figure out when the best time to merge it is.
ivanpauno
reviewed
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this feature request. The design and implementation details can also be found there.
Handling events of type
REQUESTED_INCOMPATIBLE_QOS_STATUSandOFFERED_INCOMPATIBLE_QOS_STATUS