Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RMW function to check QoS compatibility #286

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

jacobperron
Copy link
Member

Implements ros2/rmw#299

Depends on ros2/rmw_dds_common#45

Implements ros2/rmw#299

Depends on ros2/rmw_dds_common#45

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Copy link
Collaborator

@eboasson eboasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jacobperron
Copy link
Member Author

CI: ros2/rmw#299 (comment)

@jacobperron
Copy link
Member Author

@ros-pull-request-builder retest this please

@jacobperron jacobperron merged commit 609e0c8 into master Mar 1, 2021
@delete-merged-branch delete-merged-branch bot deleted the jacob/compatible_qos_api branch March 1, 2021 18:08
clalancette pushed a commit to eboasson/rmw_cyclonedds that referenced this pull request May 18, 2022
Implements ros2/rmw#299

Depends on ros2/rmw_dds_common#45

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants