build shared lib only if BUILD_SHARED_LIBS is set

[hannes09]

Signed-off-by: Hannes Harms h.harms@grimme.de

[methylDragon]

Hiya! Could I check for the reason for why you'd like to no longer be forcing SHARED library builds?

[hannes09]

The change is rquired to build ROS2 as a static set of librarys using the standart cmake feature BUILD_SHARED_LIBS=off
With this change I can link rmw_dds_common as a static lib and run ros2 applications without a ROS2 installation.

s. ros2/ros2#468

[methylDragon]

Got it! There's some internal discussion about this, and we can change it, though it'll necessitate some changes in upstream ROS libraries, so it might take a little while to resolve.

[methylDragon]

Hi there! With the merge of ament/ament_cmake#390 , we can now merge this, with one change.

Could you help to add this line here, please? Once you do I'll launch CI and work towards getting this merged!

find_package(ament_cmake REQUIRED)
find_package(rcpputils REQUIRED)
find_package(rcutils REQUIRED)
find_package(rmw REQUIRED)
find_package(rosidl_default_generators REQUIRED)

ament_add_default_options() <<<--- THIS ONE! ⭐
ament_export_dependencies(ament_cmake_core)
ament_export_dependencies(rcpputils)
ament_export_dependencies(rcutils)
ament_export_dependencies(rmw)

[methylDragon]

See above post

[methylDragon]

Bumping @hannes09

[hannes09]

I have added ament_add_default_options, but now the build fails.

[clalancette]

We need to do a release of ament_cmake. I'll get to that a little later today.

[clalancette]

@ros-pull-request-builder retest this please

[methylDragon]

I forgot ci.. my bad

• Linux
• Linux-aarch64
• Windows