Delay lock on message callback setters #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
There was a problem hiding this comment.
@MiguelCompany I think this fixes subscription problem, but the same fix should be applied to on_new_response_m_ and on_new_request_m_ as well?
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelCompany
changed the title
@fujitatomoya You are right. I've pushed the changes and also changed the PR description accordingly |
fujitatomoya
approved these changes
Jan 17, 2023
|
CI:
|
|
@fujitatomoya Do you think this can be merged? |
|
@Mergifyio backport humble |
mergify bot
pushed a commit
that referenced
this pull request
Jan 19, 2023
* Delay lock on SubListener::set_on_new_message_callback. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Delay lock on ClientListener::set_on_new_response_callback. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Delay lock on ServiceListener::set_on_new_request_callback. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit d109187)
✅ Backports have been created
|
jefferyyjhsu
pushed a commit
to irobot-ros/rmw_fastrtps
that referenced
this pull request
Jan 19, 2023
* Delay lock on SubListener::set_on_new_message_callback. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Delay lock on ClientListener::set_on_new_response_callback. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Delay lock on ServiceListener::set_on_new_request_callback. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
fujitatomoya
pushed a commit
that referenced
this pull request
Sep 5, 2023
* Delay lock on SubListener::set_on_new_message_callback. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Delay lock on ClientListener::set_on_new_response_callback. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Delay lock on ServiceListener::set_on_new_request_callback. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit d109187)
fujitatomoya
pushed a commit
that referenced
this pull request
Sep 5, 2023
* Delay lock on SubListener::set_on_new_message_callback. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Delay lock on ClientListener::set_on_new_response_callback. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Delay lock on ServiceListener::set_on_new_request_callback. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> (cherry picked from commit d109187) Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #646 by calling
get_unread_countbefore taking the lock on the mutexon_new_message_m_.It provides similar fixes for the callback setter on subscriptions, services, and clients.