Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding event and topic info functions to RMW #18

Merged
merged 15 commits into from
Apr 8, 2020
Merged

Adding event and topic info functions to RMW #18

merged 15 commits into from
Apr 8, 2020

Conversation

Karsten1987
Copy link
Collaborator

fixes #17

@Karsten1987 Karsten1987 self-assigned this Mar 26, 2020
@Karsten1987
Copy link
Collaborator Author

Current CI is only equipped to run against eloquent debs. This PR targets ROS2 master (foxy).

@jeising
Copy link
Contributor

jeising commented Mar 26, 2020 •
edited
Loading

Current CI is only equipped to run against eloquent debs. This PR targets ROS2 master (foxy).

We would need to have release branches in our package. So we could run the CI for our master against ros2 master and eloquent branch against ros2 eloquent.

@blackliner
Copy link

Current CI is only equipped to run against eloquent debs. This PR targets ROS2 master (foxy).

We would need to have release branches in our package. So we could run the CI for our master against ros2 master and eloquent branch against ros2 eloquent.

Wouldn't running rmw_iceoryx - master with ros2 - eloquent and ros2 - master ensure your rmw_iceoryx stays compatible with all supported versions? I think that would be a good thing, so you do not need to work on multiple branches?

@blackliner
Copy link

So, since https://github.com/ros2/rmw/commits/master/rmw/include/rmw/get_topic_endpoint_info.h was created 2 month ago, i guess this new feature only works with ros2:rmw - master?

@Karsten1987 Karsten1987 mentioned this pull request Mar 27, 2020
Closed
@Karsten1987
add new functions to rmw
e9d2892 
Signed-off-by: Karsten Knese <karsten.knese@us.bosch.com>
@Karsten1987
try to use ROS2 master build
900f539 
Signed-off-by: Karsten Knese <karsten.knese@us.bosch.com>
@Karsten1987
name packages to test
e1202b7 
Signed-off-by: Karsten Knese <karsten.knese@us.bosch.com>
@Karsten1987
correct path
ac67cf2 
Signed-off-by: Karsten Knese <karsten.knese@us.bosch.com>
@Karsten1987 Karsten1987 mentioned this pull request Mar 27, 2020
Closed
@Karsten1987
correct path again
5793980 
Signed-off-by: Karsten Knese <karsten.knese@us.bosch.com>

explicitly call out non-ament packages

Signed-off-by: Karsten Knese <karsten.knese@us.bosch.com>

try additional repos file

Signed-off-by: Karsten Knese <karsten.knese@us.bosch.com>

correct path of additional repos file

Signed-off-by: Karsten Knese <karsten.knese@us.bosch.com>

put it in quotes

Signed-off-by: Karsten Knese <karsten.knese@us.bosch.com>

put file in front

Signed-off-by: Karsten Knese <karsten.knese@us.bosch.com>

remove file prefix

Signed-off-by: Karsten Knese <karsten.knese@us.bosch.com>

add ros_ws

Signed-off-by: Karsten Knese <karsten.knese@us.bosch.com>

put file://`

Signed-off-by: Karsten Knese <karsten.knese@us.bosch.com>

remove file

Signed-off-by: Karsten Knese <karsten.knese@us.bosch.com>
@Karsten1987
add debug info
08d13c2 
Signed-off-by: Karsten Knese <karsten.knese@us.bosch.com>
@Karsten1987
use thomas vcs PR
b1299f8 
Signed-off-by: Karsten Knese <karsten.knese@us.bosch.com>
@Karsten1987
proper syntax
d135542 
Signed-off-by: Karsten Knese <karsten.knese@us.bosch.com>
@Karsten1987
remove tmate
3ed53f6 
Signed-off-by: Karsten Knese <karsten.knese@us.bosch.com>
@Karsten1987
no quotes
3c414c4 
Signed-off-by: Karsten Knese <karsten.knese@us.bosch.com>
@Karsten1987
prefix with file
31cae7a 
Signed-off-by: Karsten Knese <karsten.knese@us.bosch.com>
@Karsten1987
using master
e282a44 
Signed-off-by: Karsten Knese <karsten.knese@us.bosch.com>
@Karsten1987
use file on master
b0c6519 
Signed-off-by: Karsten Knese <karsten.knese@us.bosch.com>
@Karsten1987
use public gist
f20aa3f 
Signed-off-by: Karsten Knese <karsten.knese@us.bosch.com>
@Karsten1987
adopt to latest master
55ae731 
Signed-off-by: Karsten Knese <karsten.knese@us.bosch.com>
@Karsten1987 Karsten1987 requested a review from budrus April 7, 2020 01:26
@Karsten1987
Copy link
Collaborator Author

@budrus @jeising please have a look. This is ready to be merged.

I played around a little with the GitHub actions and finally landed on a private gist repo. This shall be re-iterated once ros-tooling/action-ros-ci#121 (comment) is resolved.

@Karsten1987 Karsten1987 merged commit 87a7c28 into master Apr 8, 2020
@Karsten1987 Karsten1987 deleted the fix_17 branch April 8, 2020 19:29
ZhenshengLee
ZhenshengLee reviewed Jul 1, 2021
View reviewed changes
Copy link
Contributor

@ZhenshengLee ZhenshengLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May rmw_dds_common will help to figure this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZhenshengLee ZhenshengLee ZhenshengLee left review comments

@blackliner blackliner blackliner approved these changes

@budrus budrus budrus approved these changes

Assignees

@Karsten1987 Karsten1987

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

incomplete implementation of rmw interface
5 participants
@Karsten1987 @jeising @blackliner @ZhenshengLee @budrus